Adding doctest example for image-classification pipeline.#20254
Merged
Narsil merged 2 commits intohuggingface:mainfrom Nov 16, 2022
Merged
Adding doctest example for image-classification pipeline.#20254Narsil merged 2 commits intohuggingface:mainfrom
image-classification pipeline.#20254Narsil merged 2 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
sgugger
reviewed
Nov 16, 2022
Comment on lines
45
to
48
| >>> from transformers.testing_utils import nested_simplify | ||
|
|
||
| >>> nested_simplify(potential_words) # The scores might vary slightly across pytorch/tensorflow versions. | ||
| [{'score': 0.442, 'label': 'macaw'}, {'score': 0.088, 'label': 'popinjay'}, {'score': 0.075, 'label': 'parrot'}, {'score': 0.073, 'label': 'parodist, lampooner'}, {'score': 0.046, 'label': 'poll, poll_parrot'}] |
Collaborator
There was a problem hiding this comment.
You don't need to use this, doctest will only compare the floats to the precision you write them. So the test will pass without using nested_simplify.
Contributor
Author
There was a problem hiding this comment.
Really ?? That's awesome, I can remove it in a lot of places then !
sgugger
reviewed
Nov 16, 2022
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Let's avoid using Transformers internal testing tools in examples. Rounding shouldn't be necessary, and even if it was I'd prefer to see it done in a dict comprehension, not by using nested_simplify.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
…ace#20254) * adding doctest example for `image-classification` pipeline. * Remove nested simplify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.